gh-110850: Partially revert "gh-106316: Remove pytime.h header file (#106317) #115348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ader file (python#106317)" This reverts commit 46d7761, and returns to the status quo (3.12). Tests are left in _testinternalcapi; this sounds appropriate for underscored functions.
encukou requested review from a team, pganssle, abalkin, ericsnowcurrently, ezio-melotti and hugovk as code owners 
encukou changed the title Following the recommendation in the c-analyzer traceback: Python/lock.c - TIME_TO_BE_FAIR_NS not supported (typespec (unknown)) [...] If the tool reports an unsupported global variable and it is actually const (and thus supported) then first try fixing the declaration appropriately in the code. If that doesn't work then add the variable to the "should be const" section of Tools/c-analyzer/cpython/ignored.tsv. Not sure how to fix the declaration appropriately, so adding it to the ignore list for now. It is declared as const.
encukou added the 🔨 test-with-buildbots 
bedevere-bot removed the 🔨 test-with-buildbots 
The C API WG agrees, so I suppose that this PR can be closed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If the C API WG doesn't agree on #115215, we should merge this to restore the 3.12 status quo.
📚 Documentation preview 📚: https://cpython-previews--115348.org.readthedocs.build/