Skip to content

gh-113119: Fix the macOS framework installer build #113268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2023
Merged

gh-113119: Fix the macOS framework installer build #113268

merged 2 commits into from
Dec 19, 2023

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Dec 19, 2023 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Dec 19, 2023
Closed
@gpshead gpshead added skip news OS-mac type-bug An unexpected behavior, bug, or error labels Dec 19, 2023
@gpshead gpshead changed the title gh-113117: Fix the macOS framework installer build gh-113119: Fix the macOS framework installer build Dec 19, 2023
@bedevere-app bedevere-app bot mentioned this pull request Dec 17, 2023
Closed
@gpshead gpshead marked this pull request as ready for review December 19, 2023 04:54
@gpshead gpshead requested a review from ned-deily December 19, 2023 04:55
@gpshead
Copy link
Member Author

gpshead commented Dec 19, 2023

Related: since this didn't come up in testing for the original change, it sounds like we're missing --enable-framework in either CI or buildbots?
@gpshead gpshead added 3.13 bugs and security fixes release-blocker labels Dec 19, 2023
ned-deily
ned-deily approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix.
@gpshead
Copy link
Member Author

gpshead commented Dec 19, 2023

I manually tested that building works on a mac with a configure --enable-framework - FWIW there appear to be a pile of tests that do not pass in framework builds regardless of this (looks environment related when launching python as a child process).
@gpshead gpshead merged commit c895403 into python:main Dec 19, 2023
@gpshead gpshead deleted the issue113117-macos-framework branch December 19, 2023 05:18
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@gpshead @ryan-duve
pythongh-113119: Fix the macOS framework installer build (python#113268)
ef388a4 
`--enable-framework` builds were failing. we apparently do not have good CI & buildbot coverage here.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@gpshead @aisk
pythongh-113119: Fix the macOS framework installer build (python#113268)
7fa9a0a 
`--enable-framework` builds were failing. we apparently do not have good CI & buildbot coverage here.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@gpshead @Glyphack
pythongh-113119: Fix the macOS framework installer build (python#113268)
7a9581b 
`--enable-framework` builds were failing. we apparently do not have good CI & buildbot coverage here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes OS-mac release-blocker skip news type-bug An unexpected behavior, bug, or error
2 participants
@gpshead @ned-deily