bpo-35513: Replace time.time() with time.monotonic() in tests #11182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace time.time() with time.monotonic() in tests to measure time delta.
Member Author
| Note: the PR also changes test_zipfile64 to display progress every minute (60 secs) rather than every 5 minutes (5*60 seconds). |
Contributor
| Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
| GH-11185 is a backport of this pull request to the 3.7 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 17, 2018
miss-islington added a commit that referenced this pull request Dec 17, 2018
Replace time.time() with time.monotonic() in tests to measure time delta. test_zipfile64: display progress every minute (60 secs) rather than every 5 minutes (5*60 seconds). (cherry picked from commit 2cf4c20) Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replace time.time() with time.monotonic() in tests to measure time
delta.
https://bugs.python.org/issue35513