bpo-35488: Add test for ** glob matching in pathlib #11171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tirkarthi reviewed Dec 16, 2018
brettcannon reviewed Dec 17, 2018
Lib/test/test_pathlib.py Outdated
| self.assertTrue(P('/a/b.py').match('/a/*.py')) | ||
| self.assertFalse(P('/ab.py').match('/a/*.py')) | ||
| self.assertFalse(P('/a/b/c.py').match('/a/*.py')) | ||
| # Multi-part glob-style pattern |
Member
There was a problem hiding this comment.
Suggested change
| # Multi-part glob-style pattern | |
| # Multi-part glob-style pattern. |
Contributor Author
There was a problem hiding this comment.
None of the other single-line comments in this file have periods? I can update all of them or just this one?
Member
There was a problem hiding this comment.
You can update all of them since this isn't code and it's easy to see what changed.
brettcannon approved these changes Jan 4, 2019
Member
| @tonybaloney can you add a news entry for your changes? You can use https://blurb-it.herokuapp.com/ to do it entirely in the browser. Otherwise LGTM! |
Contributor Author
| @brettcannon done! |
Member
| Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See https://bugs.python.org/issue35488
pathlib Path.match does not support glob-style ** recursive pattern matching.
Add a test to verify this behaviour as unsupported. This will also follow a documentation PR.
See also https://bugs.python.org/issue29249
https://bugs.python.org/issue35488