GH-110488: Fix two small issues in pathlib.PurePath.with_name() #110651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Ensure that `PurePath('foo/a').with_name('.')` raises `ValueError` Ensure that `PureWindowsPath('foo/a').with_name('a:b')` does not raise `ValueError`. 
JelleZijlstra approved these changes Oct 11, 2023
| Thank you, Jelle! |
| Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
| Sorry, @barneygale, I could not cleanly backport this to |
barneygale added a commit to barneygale/cpython that referenced this pull request Oct 11, 2023
…)` (python#110651) Ensure that `PurePath('foo/a').with_name('.')` raises `ValueError` Ensure that `PureWindowsPath('foo/a').with_name('a:b')` does not raise `ValueError`. (cherry picked from commit b5f7777)
barneygale added a commit to barneygale/cpython that referenced this pull request Oct 11, 2023
…h_name()` (pythonGH-110651) Ensure that `PurePath('foo/a').with_name('.')` raises `ValueError` Ensure that `PureWindowsPath('foo/a').with_name('a:b')` does not raise `ValueError`.. (cherry picked from commit b5f7777) Co-authored-by: Barney Gale <barney.gale@gmail.com>
barneygale added a commit to barneygale/cpython that referenced this pull request Oct 11, 2023
…h_name()` (pythonGH-110651) Ensure that `PurePath('foo/a').with_name('.')` raises `ValueError` Ensure that `PureWindowsPath('foo/a').with_name('a:b')` does not raise `ValueError`.. (cherry picked from commit b5f7777) Co-authored-by: Barney Gale <barney.gale@gmail.com>
| GH-110678 is a backport of this pull request to the 3.12 branch. |
barneygale added a commit that referenced this pull request Oct 11, 2023
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…)` (python#110651) Ensure that `PurePath('foo/a').with_name('.')` raises `ValueError` Ensure that `PureWindowsPath('foo/a').with_name('a:b')` does not raise `ValueError`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ensure that
PurePath('foo/a').with_name('.')raisesValueErrorEnsure that
PureWindowsPath('foo/a').with_name('a:b')does not raiseValueError.