Skip to content

GH-107263: Increase C stack limit for most functions, except _PyEval_EvalFrameDefault() #107535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 10 commits into from
Aug 4, 2023
Merged

GH-107263: Increase C stack limit for most functions, except _PyEval_EvalFrameDefault() #107535

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
18f16d3
Increase C stack limit for most functions, except PyEval_EvalDefault()
markshannon Jul 30, 2023
8d05620
Add news and what's new item.
markshannon Jul 30, 2023
aa78add
Reduce C_RECURSION_LIMIT to 2400. 2500 was too high.
markshannon Jul 30, 2023
d6793ea
Reduce C recursion limit to 2000. 2400 is too hgh for Windows.
markshannon Jul 30, 2023
c0af892
Use symbolic limit rather than hard coded value for recursion tests.
markshannon Jul 30, 2023
534a36c
Reduce C recursion limit to 1500, set cost of eval loop to 2 frames, …
markshannon Jul 30, 2023
3bb0cf0
Fix comment.
markshannon Jul 30, 2023
a8c72d0
Fix news entry
markshannon Jul 30, 2023
7e6a521
Skip test for WASI due to limited stack depth
markshannon Jul 30, 2023
0e8c992
Skip test on s390x
markshannon Jul 31, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reduce C recursion limit to 2000. 2400 is too hgh for Windows.
  • Loading branch information
@markshannon
markshannon committed Jul 30, 2023
commit d6793eac7fbd6a06ef7828bf03f26cf488c8177c
3 changes: 2 additions & 1 deletion Include/cpython/pystate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ struct _ts {
# ifdef __wasi__
# define C_RECURSION_LIMIT 500
# else
# define C_RECURSION_LIMIT 2400
// This value is duplicated in Lib/test/support/__init__.py
# define C_RECURSION_LIMIT 2000
# endif
#endif

Expand Down
3 changes: 2 additions & 1 deletion Lib/test/support/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2461,4 +2461,5 @@ def adjust_int_max_str_digits(max_digits):
#For recursion tests, easily exceeds default recursion limit
EXCEEDS_RECURSION_LIMIT = 5000

C_RECURSION_LIMIT = 2400
# The default C recursion limit (from Include/cpython/pystate.h).
C_RECURSION_LIMIT = 2000