Skip to content

bpo-34100: Partially revert merge_consts_recursive() #10743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2018
Merged

bpo-34100: Partially revert merge_consts_recursive() #10743

merged 2 commits into from
Nov 27, 2018

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Nov 27, 2018 •
edited by bedevere-bot
Loading

Partically revert commit c2e1607 to
fix a reference leak.

https://bugs.python.org/issue34100
@vstinner
bpo-34100: Partially revert merge_consts_recursive()
2e45b48 
Partically revert commit c2e1607 to fix a reference leak.
@vstinner vstinner requested a review from methane November 27, 2018 13:33
@methane
Copy link
Member

methane commented Nov 27, 2018

I'd like to leave some comment like // Limitation: We don't merge frozenset for now.
@vstinner
Copy link
Member Author

vstinner commented Nov 27, 2018

I'd like to leave some comment like // Limitation: We don't merge frozenset for now.

I wrote a quick & dirty fix, just to repair the CI. I know that you will work hard to write a proper fix :-)
@vstinner vstinner merged commit 1005c84 into python:master Nov 27, 2018
@vstinner vstinner deleted the revert_merge_consts branch November 27, 2018 14:12
methane added a commit to methane/cpython that referenced this pull request Nov 28, 2018
@methane
Revert "bpo-34100: Partially revert merge_consts_recursive() (pythonG…
77ca8b0 
…H-10743)" This reverts commit 1005c84.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news

4 participants

@vstinner @methane @the-knights-who-say-ni @bedevere-bot