gh-89886: Rely on HAVE_SYS_TIME_H #105058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Quoting autoconf (v2.71): All current systems provide time.h; it need not be checked for. Not all systems provide sys/time.h, but those that do, all allow you to include it and time.h simultaneously.
erlend-aasland added the 🔨 test-with-buildbots 
| 🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit de000c6 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
brettcannon approved these changes May 29, 2023
Contributor Author
| On hold until |
zware reviewed May 30, 2023
Simply use ac_cv_header_sys_time_h for PY_STDLIB_MOD
erlend-aasland commented May 30, 2023
Contributor Author
| Ok, I think we can land this now. Thanks for the review! It helps with more eyes 👀 |
Contributor
| Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2023
Quoting autoconf (v2.71): All current systems provide time.h; it need not be checked for. Not all systems provide sys/time.h, but those that do, all allow you to include it and time.h simultaneously. (cherry picked from commit 9ab587b) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
| GH-105192 is a backport of this pull request to the 3.12 branch. |
erlend-aasland added a commit that referenced this pull request Jun 1, 2023
Quoting autoconf (v2.71): All current systems provide time.h; it need not be checked for. Not all systems provide sys/time.h, but those that do, all allow you to include it and time.h simultaneously. (cherry picked from commit 9ab587b) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
This was referenced Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Quoting autoupdate (v2.71):