[3.8] gh-102153: Start stripping C0 control and space chars in `urlsp… #104918
+111 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ngie-eign force-pushed the 3.8-CVE-2023-24329 branch from 8ac91e7 to 9048acb Compare 
…`urlsplit` pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508) `urllib.parse.urlsplit` has already been respecting the WHATWG spec a bit pythonGH-25595. This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329). I simplified the docs by eliding the state of the world explanatory paragraph in this security release only backport. (people will see that in the mainline /3/ docs) Co-authored-by: Illia Volochii <illia.volochii@gmail.com> Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org> Co-authored-by: Enji Cooper <yaneurabeya@gmail.com>
ngie-eign force-pushed the 3.8-CVE-2023-24329 branch from 9048acb to 737be53 Compare 
Member
| Thanks for the PR. However, a backport to 3.8 for this issue already exists as pending PR #104895. |
Contributor Author
Wonderful -- thank you for the heads up! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…lit`
gh-102153: Start stripping C0 control and space chars in
urlsplit(GH-102508)urllib.parse.urlsplithas already been respecting the WHATWG spec a bit GH-25595.This adds more sanitizing to respect the "Remove any leading C0 control or space from input" rule in response to CVE-2023-24329.
I simplified the docs by eliding the state of the world explanatory paragraph in this security release only backport. (people will see that in the mainline /3/ docs)
PR Note
This is a manual back port of the fix originally pushed to main as 2f630e1.