bpo-35213: Where appropriate, use 'macOS' in idlelib. #10478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
matrixise requested changes Nov 12, 2018
Member
matrixise left a comment
matrixise left a comment There was a problem hiding this comment.
Hi @terryjreedy
I found some occurrences of OS X in Doc/library/idle.rst
and in these files:
Lib/idlelib/NEWS.txt Lib/idlelib/NEWS2x.txt Lib/idlelib/config.py Lib/idlelib/editor.py Lib/idlelib/help.html Lib/idlelib/macosx.py Lib/idlelib/mainmenu.py Lib/idlelib/pyshell.py Doc/library/idle.rst the current Mac keyset is named 'IDLE Classic OSX'.
Member Author
| @matrixise Thank you for the search. I made changes in idle.rst (help.html) and config.py, though I am not completely sure of the latter. I explained non-changes in a post to the issue and asked Ned Deily a few questions. |
| @terryjreedy: Please replace |
Contributor
| Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2018
(cherry picked from commit b65413b) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
| GH-10559 is a backport of this pull request to the 3.7 branch. |
| GH-10560 is a backport of this pull request to the 3.6 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2018
(cherry picked from commit b65413b) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Nov 15, 2018
miss-islington added a commit that referenced this pull request Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35213