Skip to content

[WIP] GH-89812: Add tarfile.TarPath #104272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[WIP] GH-89812: Add tarfile.TarPath #104272

wants to merge 2 commits into from

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented May 7, 2023 •
edited
Loading

  • Split pathlib.Path into _AbstractPath and Path
    • Make _AbstractPath.stat(), open() and iterdir() abstract
    • Implement _AbstractPath._scandir() via iterdir()
      • Add follow_symlinks argument to is_dir() for consistency with os.DirEntry.is_dir()
      • Use context manager enter value in walk() to enable use of a contextlib.nullcontext()
    • Implement _AbstractPath.is_mount() and is_junction() using stat(), restoring implementation from before gh-86943: implement pathlib.WindowsPath.is_mount() #31458 in the former case.
  • [more to come!]
@bedevere-bot bedevere-bot mentioned this pull request May 7, 2023
Open
@barneygale
Copy link
Contributor Author

Closing - will log a fresh PR soon :)
@barneygale barneygale closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review topic-pathlib
2 participants
@barneygale @bedevere-bot