Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 11, 2023

Now, we can use a default signature by catching some of the exceptions.
As the second option - we can catch all exceptions here.

@Eclips4
Copy link
Member

Eclips4 commented Apr 11, 2023

Thanks for fix, Nikita!
Also, this reproducible on 3.11, so, I think this should be merged to 3.11 and current branch.
(Although, reproducible on 3.9 & 3.10, but it's not a security fix)

@Eclips4
Copy link
Member

Eclips4 commented Apr 11, 2023

However, functional of Test.__doc__ (where Test is a dataclass) is not documented.

@carljm carljm added the needs backport to 3.11 only security fixes label Apr 17, 2023
@carljm carljm merged commit b57f55c into python:main Apr 17, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @sobolevn and @carljm, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker b57f55c23e15654e9dd77680ff1462603e360b76 3.11

@carljm carljm added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Apr 17, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 17, 2023
…H-103454) (cherry picked from commit b57f55c) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-103599 is a backport of this pull request to the 3.11 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants