Skip to content

gh-103023: Add SyntaxError check in pdb's display command #103024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ambv merged 7 commits into from
Mar 27, 2023
Merged

gh-103023: Add SyntaxError check in pdb's display command #103024

ambv merged 7 commits into from
Mar 27, 2023

Conversation

@gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Mar 25, 2023 •
edited by bedevere-bot
Loading

In this PR, extra stuff was cleaned up a bit:

  1. sys.exc_info() is no longer needed now that format_exception_only supported exception object directly.
  2. A clearer message is sent to the users when no expression is being displayed
@bedevere-bot bedevere-bot mentioned this pull request Mar 25, 2023
Closed
sunmy2019
sunmy2019 requested changes Mar 25, 2023
View reviewed changes
sunmy2019
sunmy2019 requested changes Mar 26, 2023
View reviewed changes
@ambv ambv merged commit 3606753 into python:main Mar 27, 2023
@gaogaotiantian gaogaotiantian deleted the display-syntax-error branch March 27, 2023 21:16
@arhadthedev arhadthedev mentioned this pull request Mar 30, 2023
Merged
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@gaogaotiantian @ambv @warsaw
pythongh-103023: Add SyntaxError check in pdb's display command (py…
6ddabe1 
…thon#103024) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@gaogaotiantian @sunmy2019 @ambv @bedevere-bot