Skip to content

gh-101907: Removes use of non-standard C++ extension from Include/cpython/code.h #101909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

gh-101907: Removes use of non-standard C++ extension from Include/cpython/code.h #101909

wants to merge 2 commits into from

Conversation

zooba
Copy link
Member

@zooba zooba commented Feb 14, 2023 •
edited by bedevere-bot
Loading

Updates all references to use the macros, so that changes are localised to the header file.
@bedevere-bot bedevere-bot mentioned this pull request Feb 14, 2023
Closed
@zooba
Copy link
Member Author

zooba commented Feb 14, 2023

Another possible fix (that I haven't tested yet) would be to move this struct into a private header. I don't have any strong preference, but I'm also not familiar with its background and intended use.
@markshannon
Copy link
Member

markshannon commented Feb 14, 2023 •
edited
Loading

This is C11, not C++.

What problem is this causing? Looks like I should have read the issue.
@markshannon
Copy link
Member

Anonymous unions are quite useful, especially for inserting unions into a struct and retaining API compatibility. It's a shame we can't use them.
@zooba
Copy link
Member Author

zooba commented Feb 14, 2023

I agree they're useful, but I don't need to be convinced. We have to win over the C++ committee 😄 And then wait a decade for it to be generally available in all the compilers we support.

Incidentally, I noticed the SET macro, so I fixed it and am switching the assignments to use that.
@zooba
Copy link
Member Author

zooba commented Feb 14, 2023

#101912 is an alternate PR to this one
@zooba
Copy link
Member Author

zooba commented Feb 15, 2023

We prefer #101912
@zooba zooba closed this Feb 15, 2023
@zooba zooba deleted the gh-101907 branch February 15, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review

3 participants

@zooba @markshannon @bedevere-bot