bpo-29474: Improve documentation for weakref.WeakValueDictionary #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| Not sure if I'm doing this right. |
Member
| @Mariatta Yes, as far as I know :) |
zware approved these changes Feb 11, 2017
There were some grammatical errors in weakref.WeakValueDictionary documentation.
Codecov Report@@ Coverage Diff @@ ## master #10 +/- ## ========================================== + Coverage 82.37% 82.37% +<.01% ========================================== Files 1427 1427 Lines 350948 350948 ========================================== + Hits 289088 289091 +3 + Misses 61860 61857 -3Continue to review full report at Codecov.
|
This was referenced Feb 11, 2017
emmatyping referenced this pull request in emmatyping/cpython Feb 7, 2020
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Nov 22, 2022
jaraco pushed a commit that referenced this pull request Dec 2, 2022
oraluben referenced this pull request in oraluben/cpython Jun 25, 2023
Co-authored-by: Jules <57632293+JuliaPoo@users.noreply.github.com>
This was referenced Feb 11, 2025
DinoV added a commit to DinoV/cpython that referenced this pull request Oct 20, 2025
Update sys module to conform with the PEP, add matching C API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There were some grammatical errors in weakref.WeakValueDictionary
documentation.
This should be applied to 3.5, 3.6, and master.
Original patch was in bpo http://bugs.python.org/file46597/issue29474py3-2.patch