Skip to content

TESTSUBDIRS missing some test directories #98822

@asottile

Description

@asottile

Bug report

I noticed this when test_sqlite3 was missing from the installed tests

Your environment

3.11+ though I suspect some other versions might have inaccurate testdir listings too

here's the missing ones for the current primary branch for example:

diff --git a/Makefile.pre.in b/Makefile.pre.in index 9961a864cb..9a19b5c147 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -1963,6 +1963,7 @@ LIBSUBDIRS=	asyncio \	xmlrpc \	zoneinfo \	__phello__ +# find Lib/test/ -type d | cut -d/ -f2- | sort | grep -Ev '(crashers|leakers)' | xargs --replace echo $'\t\t{} \\' TESTSUBDIRS=	distutils/tests \	idlelib/idle_test \	test \ @@ -1972,7 +1973,6 @@ TESTSUBDIRS=	distutils/tests \	test/data \	test/decimaltestdata \	test/dtracedata \ -test/eintrdata \	test/encoded_modules \	test/imghdrdata \	test/libregrtest \ @@ -2039,7 +2039,26 @@ TESTSUBDIRS=	distutils/tests \	test/test_lib2to3/data/fixers \	test/test_lib2to3/data/fixers/myfixes \	test/test_peg_generator \ +test/test_sqlite3 \	test/test_tkinter \ +test/test_tomllib \ +test/test_tomllib/data \ +test/test_tomllib/data/invalid \ +test/test_tomllib/data/invalid/array \ +test/test_tomllib/data/invalid/array-of-tables \ +test/test_tomllib/data/invalid/boolean \ +test/test_tomllib/data/invalid/dates-and-times \ +test/test_tomllib/data/invalid/dotted-keys \ +test/test_tomllib/data/invalid/inline-table \ +test/test_tomllib/data/invalid/keys-and-vals \ +test/test_tomllib/data/invalid/literal-str \ +test/test_tomllib/data/invalid/multiline-basic-str \ +test/test_tomllib/data/invalid/multiline-literal-str \ +test/test_tomllib/data/invalid/table \ +test/test_tomllib/data/valid \ +test/test_tomllib/data/valid/array \ +test/test_tomllib/data/valid/dates-and-times \ +test/test_tomllib/data/valid/multiline-basic-str \	test/test_tools \	test/test_ttk \	test/test_unittest \

let me know if you'd like me to send patch(es) or if there's a more programmatic way to handle this

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildThe build process and cross-buildtestsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions