test_zoneinfo_property.py misses tests with all pickle protocols

cpython/Lib/test/test_zoneinfo/test_zoneinfo_property.py

Lines 145 to 162 in d1d5dce

     @hypothesis.given(key=valid_keys())  
   @add_key_examples  
   def test_pickle_unpickle_cache(self, key):  
   zi = self.klass(key)  
   pkl_str = pickle.dumps(zi)  
   zi_rt = pickle.loads(pkl_str)  
    
   self.assertIs(zi, zi_rt)  
    
   @hypothesis.given(key=valid_keys())  
   @add_key_examples  
   def test_pickle_unpickle_no_cache(self, key):  
   zi = self.klass.no_cache(key)  
   pkl_str = pickle.dumps(zi)  
   zi_rt = pickle.loads(pkl_str)  
    
   self.assertIsNot(zi, zi_rt)  
   self.assertEqual(str(zi), str(zi_rt))  
 

We should add all protocols to the test, since it might affect the property based testing.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

`test_zoneinfo_property.py` misses tests with all `pickle` protocols #136297

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	@hypothesis.given(key=valid_keys())
	@add_key_examples
	def test_pickle_unpickle_cache(self, key):
	zi = self.klass(key)
	pkl_str = pickle.dumps(zi)
	zi_rt = pickle.loads(pkl_str)

	self.assertIs(zi, zi_rt)

	@hypothesis.given(key=valid_keys())
	@add_key_examples
	def test_pickle_unpickle_no_cache(self, key):
	zi = self.klass.no_cache(key)
	pkl_str = pickle.dumps(zi)
	zi_rt = pickle.loads(pkl_str)

	self.assertIsNot(zi, zi_rt)
	self.assertEqual(str(zi), str(zi_rt))

Uh oh!

test_zoneinfo_property.py misses tests with all pickle protocols #136297

Description

Linked PRs

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`test_zoneinfo_property.py` misses tests with all `pickle` protocols #136297