Skip to content

blake2-config.h HAVE_SSE4_1 typo fix #102027

Closed
@nono303

Description

@nono303

Bug report

Unable to compile cpython on Windows with AVX enable

  1. adding <EnableEnhancedInstructionSet>AdvancedVectorExtensions</EnableEnhancedInstructionSet> for </ClCompile> in vcxproj files (result /arch:AVX in cl.exe cmd line)
  2. MSBuild.exe C:\sdk\src\python\PCbuild\pcbuild.proj /nologo /nr:false /m:16 /p:Turbo=true /p:CL_MPCount=16 /p:RunCodeAnalysis=false /p:DebugType=None /p:DebugSymbols=true /p:WindowsTargetPlatformVersion=10.0.22621.0 /p:PlatformToolset=v143 /clp:EnableMPLogging;Summary;ShowCommandLine /v:d /p:Configuration=Release /p:Platform="x64" /p:IncludeExtensions=true /p:IncludeExternals=true /p:IncludeTests=false /p:IncludeCTypes=true /p:IncludeSSL=true /p:IncludeTkinter=false /p:IncludeUwp=true /t:RebuildAll /p:EXTERNALS_DIR="C:\sdk\release\vs17_x64-avx" /p:ExternalsSrcDir="C:\sdk\src" /p:_DLLSuffix=-81_3-x64 /p:SqliteVersionStrToParse=3.40.1.0 /nowarn:C4244
  3. result:

C:\sdk\src\python\Modules_blake2\impl\blake2-config.h(67,1): fatal error C1189: #error: "This code requires at least SSE2." (compiling source file ..\Modules_blake2\blake2s_impl.c) [C:\sdk\src\python\PCbuild\pythoncore.vcxproj]
C:\sdk\src\python\Modules_blake2\impl\blake2-config.h(67,1): fatal error C1189: #error: "This code requires at least SSE2." (compiling source file ..\Modules_blake2\blake2b_impl.c) [C:\sdk\src\python\PCbuild\pythoncore.vcxproj]

It's just a typo issue in Modules/_blake2/impl/blake2-config.h

diff --git "a/Modules/_blake2/impl/blake2-config.h" "b/Modules/_blake2/impl/blake2-config.h" index f5dd6faa9e..c09cb4bcf0 100644 --- "a/Modules/_blake2/impl/blake2-config.h" +++ "b/Modules/_blake2/impl/blake2-config.h" @@ -53,7 +53,7 @@ #endif #endif -#ifdef HAVE_SSE41 +#ifdef HAVE_SSE4_1 #ifndef HAVE_SSSE3 #define HAVE_SSSE3 #endif 

The patch fix the issue
Seems to be present on every branch

Your environment

  • CPython versions tested on: branch 3.8 / tag 3.8.16
  • Operating system and architecture: Win64 vs17 AVX

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildThe build process and cross-buildextension-modulesC modules in the Modules dirtopic-SSLtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions