Skip to content

Gracefully closing the cli when KeyboardInterrupt signal is sent #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+2 −1
Closed

Gracefully closing the cli when KeyboardInterrupt signal is sent #1599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
383bcef
Catching asyncio.CancelledError instead of KeyboardInterrupt and EOFE…
a-alak Feb 25, 2025
8256e80
formatting change
a-alak Feb 25, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/websockets/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import asyncio
import os
import sys
from asyncio import CancelledError
from typing import Generator

from .asyncio.client import ClientConnection, connect
Expand Down Expand Up @@ -123,7 +124,7 @@ async def interactive_client(uri: str) -> None:
[incoming, outgoing],
return_when=asyncio.FIRST_COMPLETED,
)
except (KeyboardInterrupt, EOFError): # ^C, ^D # pragma: no cover
except CancelledError: # ^C, ^D # pragma: no cover
pass
finally:
incoming.cancel()
Expand Down