CI: run Geopandas tests #2116
Merged
CI: run Geopandas tests #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
martinfleis reviewed Mar 16, 2025
This reverts commit c24b132.
Conengmo commented Mar 16, 2025
.github/workflows/test_geopandas.yml Outdated
| - name: Install Geopandas dev dependencies | ||
| run: | | ||
| pip install -r geopandas/requirements-dev.txt | ||
| pip install geodatasets |
Member Author
There was a problem hiding this comment.
@martinfleis I was a bit surprised that I had to install geodatasets separately, is that expected? Or did I mis something? I don't mind, just checking.
Collaborator
There was a problem hiding this comment.
Need to update requirements-dev. Sorry for that, we're not really using it.
martinfleis reviewed Mar 17, 2025
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add a workflow to run the Geopandas tests on the dev version of Folium.
Verified this works by pushing a commit to Folium that breaks the Geopandas tests, then restoring it of course.