Replace deprecated classifier with licence expression (PEP 639) #8850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
radarhere approved these changes Apr 4, 2025
Member
The description of pyroma is https://pypi.org/project/pyroma/
That sounds like something we would be interested in. Is your feeling just that pyroma is slipping in achieving that goal, or that we have other checks that make this redundant? You added the test in #743 in response to @aclark4life's #740. If you both don't mind removing it, then that sounds fine - in practical terms, it's hard to remember another time when it has failed. |
Member Author
| The #740 failure looked more an artifact of pyroma itself, rather than our packaging? Perhaps it is still useful to prevent regressions? I did try adding coverage to tox recently (Python only, not C) and most tests use the PIL source under With test_pyromaDisabling Without test_pyroma |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Setuptools 77 now supports PEP 639 licence metadata:
This PR adds MIT-CMU as an SPDX licence expression, adds an explicit
license-filesfield (I think we could leave it out and a glob would match, but perhaps explicit is better) and removes the deprecated Trove licence classifier.Also adjust the pyroma test because it does not support PEP 639 yet: regebro/pyroma#93. In fact, any objections to removing the test file and dependency altogether? I don't think it's especially helpful now.