Support saving DDS images with pixel formats #8807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
radarhere changed the title radarhere force-pushed the dxt1 branch 3 times, most recently from a87b85f to 4e1b4e3 Compare radarhere changed the title radarhere changed the title radarhere changed the title radarhere changed the title This was referenced Mar 15, 2025
radarhere added a commit to radarhere/Pillow that referenced this pull request Mar 19, 2025
radarhere added a commit to radarhere/Pillow that referenced this pull request Mar 19, 2025
radarhere added a commit to radarhere/Pillow that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #4864
Resolves #5499
With this, DXT1, DXT3, DXT5, BC2, BC3 and BC5 DDS images can be saved, with
rather than saving uncompressed data. I've also added the loading of BC2 and BC3 images, since they were missing.
See https://learn.microsoft.com/en-us/windows/win32/direct3d10/d3d10-graphics-programming-guide-resources-block-compression#bc1 for documentation (DXT1 is also known as BC1, DXT3 is also known as BC2 and DXT5 is also known as BC3).
For the BC2, BC3 and BC5 format, see https://learn.microsoft.com/en-us/windows/win32/direct3ddds/dx-graphics-dds-pguide#dds-file-layout