Add zizmor to pre-commit and fix potential cache-poisoning in wheels workflow #8638
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow on from #8526.
Add zizmor to pre-commit, run the new version 0.10.0, and fix the one new thing it finds:
More info: https://woodruffw.github.io/zizmor/audits/#cache-poisoning
In short, the idea is not to use caches in workflows that produce release artifacts.
This featured in the recent Ultralytics supply chain attack:
We don't run the wheels workflow that often, and the main time bottleneck is building and testing all the wheels, so it's not a big loss to download things from PyPI each time.