Fixed orientation when opening YCbCr TIFF images #8556
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #8554
When a TIFF image is YCbCr, Pillow calls libtiff's
TIFFRGBAImageBeginPillow/src/libImaging/TiffDecode.c
Line 729 in 5bff2f3
Pillow/src/libImaging/TiffDecode.c
Lines 739 to 740 in 5bff2f3
Pillow/src/libImaging/TiffDecode.c
Line 295 in 5bff2f3
Looking at that libtiff code, it then calls either
PickContigCaseorPickSeparateCase. Those setimg->gettogtTileContig,gtStripContig,gtTileSeparateorgtStripSeparate. All four of those functions apply orientation to the image based onimg->orientation.Pillow expects to manage image orientation itself. This PR sets
img.orientationto prevent libtiff from doing so.