Deprecate ImageDraw.getdraw hints parameter #8124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hugovk approved these changes Jun 10, 2024
Member
hugovk left a comment
hugovk left a comment There was a problem hiding this comment.
This will be related to Fredrik Lundh's aggdraw project: "An add-on to the PIL library that supports anti-aliased drawing".
However, I don't find any reference to _imagingagg in the 2005 source download at https://web.archive.org/web/20200220003311/http://www.effbot.org/downloads/#aggdraw or in any of the code or commits of the fork at https://github.com/pytroll/aggdraw.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
radarhere commented Jun 10, 2024
Member
| The 3.13 failures are unrelated: actions/setup-python#886 We can work around by pinning to |
Member Author
| 3.13 is back to passing now. |
radarhere changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ImageDraw.getdraw()has ahintsargument. Its purpose is to indicate whether or not_imagingaggshould be used instead ofImageDraw2.However,
_imagingaggdoesn't exist, so I suggest deprecating thehintsargument.