Add type hints to `Image.py` #7924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

mergify merged 3 commits into python-pillow:main from hugovk:image-type-hints

Apr 1, 2024

Member

hugovk commented Mar 31, 2024

Still some to do later.

hugovk added the Type hints label

hugovk force-pushed the image-type-hints branch from d2ec75a to c6e65e8 Compare

March 31, 2024 16:15

nulano reviewed

View reviewed changes

src/PIL/Image.py Outdated Show resolved Hide resolved

src/PIL/Image.py Outdated Show resolved Hide resolved

hugovk force-pushed the image-type-hints branch from 397de28 to 8c9621b Compare

March 31, 2024 19:04

Add type hints

b6c755d

Co-authored-by: Ondrej Baranovič <ondreko.tiba@gmail.com>

hugovk force-pushed the image-type-hints branch from 8c9621b to b6c755d Compare

March 31, 2024 19:05

radarhere reviewed

View reviewed changes

src/PIL/Image.py Outdated Show resolved Hide resolved

radarhere reviewed

View reviewed changes

src/PIL/Image.py Outdated Show resolved Hide resolved

radarhere reviewed

View reviewed changes

src/PIL/Image.py Outdated Show resolved Hide resolved

radarhere reviewed

View reviewed changes

src/PIL/Image.py Outdated Show resolved Hide resolved

Add type hints

008b28e

Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>

radarhere reviewed

View reviewed changes

src/PIL/Image.py Outdated Show resolved Hide resolved

hugovk commented

View reviewed changes

src/PIL/Image.py Outdated Show resolved Hide resolved

Add type hints

7c5d0b9

Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>

radarhere approved these changes

View reviewed changes

hugovk added the automerge label

Contributor

Yay295 commented Apr 1, 2024

I think ImagingCore would be typed as typing.Any, pending a more concrete definition. Though I suppose leaving it untyped for now works as well.

mergify bot merged commit 835ca1b into python-pillow:main

hugovk deleted the image-type-hints branch

April 1, 2024 06:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment