Changed IPTC tile tuple to match other plugins #7661
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Looking at
Pillow/src/PIL/IptcImagePlugin.py
Lines 131 to 133 in 0988703
I find this odd, as it does not match the structure that we otherwise have for
self.tile.Pillow/src/PIL/ImageFile.py
Lines 93 to 97 in 0988703
Pillow/src/PIL/JpegImagePlugin.py
Line 396 in 0988703
The reason this problem has not been found by the test suite is that no test actually opens a valid IPTC image.
This PR changes the
self.tiletuple to match the format used in other plugins.I've reversed-engineered test data for
_openfrom the code.