Skip to content

Use list comprehensions to create transformed lists #7597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radarhere merged 4 commits into from
Dec 5, 2023
Merged

Use list comprehensions to create transformed lists #7597

radarhere merged 4 commits into from
Dec 5, 2023

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Dec 3, 2023

Changes proposed in this pull request:

  • Replace some for loops with list comprehensions
  • Identified with ruff . --select PERF401: "PERF401 Use a list comprehension to create a transformed list"
  • https://docs.astral.sh/ruff/rules/manual-list-comprehension/
  • It finds some that can't be easily replaced, so I didn't add this rule to pyproject.toml
Yay295
Yay295 reviewed Dec 3, 2023
View reviewed changes
@radarhere radarhere mentioned this pull request Dec 4, 2023
Closed
radarhere
radarhere reviewed Dec 4, 2023
View reviewed changes
homm
homm reviewed Dec 4, 2023
View reviewed changes
src/PIL/ImageStat.py Outdated
v.append(functools.reduce(operator.add, self.h[i : i + 256]))
return v
return [
functools.reduce(operator.add, self.h[i : i + 256])
Copy link
Member

@homm homm Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7599
hugovk
hugovk commented Dec 4, 2023
View reviewed changes
hugovk and others added 2 commits December 4, 2023 16:34
@hugovk @radarhere @homm
Apply suggestions from code review
e92c07f 
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com> Co-authored-by: Alexander Karpinsky <homm86@gmail.com>
@hugovk
Merge branch 'main' into comprehensions
9601102
radarhere
radarhere reviewed Dec 4, 2023
View reviewed changes
@hugovk @radarhere
Use underscore as throwaway variable
f7c3f2a 
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
@radarhere radarhere merged commit 0a66b98 into python-pillow:main Dec 5, 2023
@radarhere radarhere mentioned this pull request Dec 5, 2023
Merged
@hugovk hugovk deleted the comprehensions branch December 5, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Performance

5 participants

@hugovk @homm @radarhere @nulano @Yay295