Added messages to errors #7480
Merged
Added messages to errors #7480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nulano reviewed Oct 19, 2023
Tests/test_file_palm.py Outdated
Comment on lines 29 to 30
| if rc: | ||
| raise OSError | ||
| assert False |
Contributor
There was a problem hiding this comment.
Would this work/be clearer?
- if rc: - raise OSError + assert not rc Member Author
There was a problem hiding this comment.
Sure, that also works. I've made that change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In main, lint has started insisting that "Built-in Exceptions must not be thrown without being called" and "Built-in Exceptions must have a useful message" - https://github.com/python-pillow/Pillow/actions/runs/6570025729/job/17846816725#step:7:63
This PR adds messages to errors when they are raised, and replaces an error raised in the tests with a failed assertion.