Support pypy3 #187
Support pypy3 #187
Conversation
| I'm not sure I understand this PR. I happen to have found https://bitbucket.org/pypy/pypy/issue/1889/attributeerror-importing-module by chance, which appears to have been filed by you -- it would have been nice to include it as some context. But as pjenvey has already mentioned, I'm not sure what benefit this change would have, since jsonschema does not support Python 3.2, it's 3.3+. If I've gotten any of that wrong, feel free to reopen. |
| I can agree with dropping 3.2 support, but there's no "better" version of pypy3, and the only necessary changes are small. They won't regress because of the addition to CI. |
| Unprivileged users can't reopen tickets =/ |
| Yeah, sorry, only the OP and collaborators can, which is a bit annoying. My point was that these changes are necessary only to support a version that will never work -- for the next version of PyPy they're not necessary, so I don't personally see a point in merging them. I'm opened to being convinced though if you see some value in them. |
| I'm under the impression it does work, given that all of your tests pass. |
| Huh. For some reason pypy3 seems to support unicode literals. I was assuming the tests couldn't pass, but it does appear that given the syntax support they do. That's weird, but possibly changes things. I'll try and take another look at the changes. |
| Yes pypy3 is python3.2 plus the u'' literal (pep414). They did it for exactly the reason at hand; some project could only support pypy3 if they had the u'' literal available. |
| Any blocking issue? |
There was a problem hiding this comment.
- lxml dies for whatever reason under pypy3
- I was making the py34 target more like the other py* targets
- I removed lxml because it wasn't necessary for testing jsonschema, only necessary for building docs
If there's a better way to adjust this I'd be happy to do so :)
| This is fixed upstream now, so merged -- thanks a lot! Sorry for the wait. |
3 participants
No description provided.