Drop Python 3.9, add 3.12; update pre-commit #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@ ## main #84 +/- ## ========================================== - Coverage 76.84% 76.82% -0.03% ========================================== Files 118 118 Lines 4272 4271 -1 Branches 818 818 ========================================== - Hits 3283 3281 -2 - Misses 749 751 +2 + Partials 240 239 -1 |
eriknw commented Dec 13, 2023
Comment on lines +295 to +304
| # key("test_binary.py:test_compose_multigraph"): multigraph, | ||
| # key("test_binary.py:test_difference_multigraph_attributes"): multigraph, | ||
| # key("test_binary.py:test_disjoint_union_multigraph"): multigraph, | ||
| # key("test_binary.py:test_full_join_multigraph"): multigraph, | ||
| # key("test_binary.py:test_intersection_multigraph_attributes"): multigraph, | ||
| # key( | ||
| # "test_binary.py:test_intersection_multigraph_attributes_node_set_different" | ||
| # ): multigraph, | ||
| # key("test_binary.py:test_symmetric_difference_multigraph"): multigraph, | ||
| # key("test_binary.py:test_union_attributes"): multi_attributed, |
There was a problem hiding this comment.
Before I delete these, I want to verify that we expect these tests to pass. I probably made a change earlier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
NetworkX dropped Python 3.9, so we are too.