Added typing support to json_support.py #780
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As per our discussion, I have started to add typing support with
json_support.pyfile,and here are the notes we have on the way:
2.0.0-alpha.1it is impossible to install:gino[starlette, aiohttp, tornado, sanic, quart]as they are all required the gino version to be < 2.0.0. To proceed I have disabled them inpyptoject.toml.poetry.lockfilemypyto0.812in order to getsqlalchemy2-stubsworks with - updated thepyproject.tomlaccordingly.sqlalchemyis a local path, I have cloned the master branch ofsqlalchemyand started to work on it(current version is1.4.16)What I did so far:
mypy.inifile with "strict" mode is added.You should notice that most of the methods are accepting Any and returning Any, this is also true for sqlalchemy2-stubs base_exp is Any and
astextis Any also it seems to be thecastmethod also returns Any type :)