Skip to content

Madlibs - Add "End Game" and "Choose for me" buttons #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Madlibs - Add "End Game" and "Choose for me" buttons #1690

wants to merge 1 commit into from

Conversation

DMFriends
Copy link
Contributor

Relevant Issues

Closes #1000

Description

  • Added an "End Game" button to end the game in case a user decides not to play after starting a game.
  • Added a "Choose for me" button that randomly chooses a word from the madlibs_word_bank.json file and adds it to the Madlib in case the user can't think of a good word to use for the given part of speech.
  • As I was writing the code for the "Choose for me" button, I realized that it wouldn't make sense not to add a cooldown for the button so the user cannot spam it, so I added that as well, although it wasn't part of my original proposal in the issue.
  • Also not part of the original issue but changed the timeout from 60 seconds to 120 seconds because 60 seconds felt too short to me.
  • Had to also make a few minor changes to the original implementation of the game (which I wrote) to make it work with the new buttons.

Did you:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@DMFriends