Improve UX during errors while parsing warning filters #9223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nicoddemus force-pushed the better-filter-warnings-messages branch from c0b7c5f to 6bb36bd Compare 
| Instead of an internal traceback on errors, we get a much nicer error message: |
nicoddemus force-pushed the better-filter-warnings-messages branch 2 times, most recently from 4fc2b2f to 9dcf55e Compare 
nicoddemus force-pushed the better-filter-warnings-messages branch from 9dcf55e to f5fd2fb Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #7864
Fix #9218
Closes #8343
Closes #7877