Skip to content

Conversation

Naveen-Pratap
Copy link
Contributor

@Naveen-Pratap Naveen-Pratap commented Jul 14, 2021

Closes #8432

@nicoddemus
Copy link
Member

Thanks @Naveen-Pratap, we appreciate the contribution!

Took the liberty of tweaking the changelog message a bit. 👍

@nicoddemus nicoddemus changed the title Closes #8432 - Update error message for module level skip to include 'allow_module_level'. Update error message for module level skip to include 'allow_module_level' Jul 14, 2021
@nicoddemus nicoddemus enabled auto-merge (squash) July 14, 2021 12:28
@bluetech bluetech disabled auto-merge July 14, 2021 12:29
Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a few tweaks to the message.

@Naveen-Pratap Naveen-Pratap force-pushed the 8432-improve-handling-module-level-skip branch from b5ee3bf to 3035476 Compare July 14, 2021 13:42
@bluetech bluetech enabled auto-merge (squash) July 14, 2021 14:09
@bluetech bluetech merged commit febb978 into pytest-dev:main Jul 14, 2021
@Naveen-Pratap Naveen-Pratap deleted the 8432-improve-handling-module-level-skip branch July 14, 2021 14:59
RonnyPfannschmidt pushed a commit to RonnyPfannschmidt/pytest that referenced this pull request Oct 1, 2021
…evel' (pytest-dev#8906) Co-authored-by: Naveen <NaveenPr1@microland.com> Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants