Skip to content

feat: add --require-unique-paramset-ids option skips pytest internal … #13757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add --require-unique-paramset-ids option skips pytest internal … #13757

wants to merge 1 commit into from
+145 −0

Conversation

gomri15
Copy link

@gomri15 gomri15 commented Sep 26, 2025 •
edited by Zac-HD
Loading

  • Added flag to skip attempting to generate parametrization ids and just raise error on duplicate ids during collection

Closes #13737
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Sep 26, 2025
Zac-HD
Zac-HD reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should i documentation like there is for --collect-only?

Yes please - and then I think we'll be ready to merge 🙂
nicoddemus
nicoddemus requested changes Sep 27, 2025
View reviewed changes
@nicoddemus nicoddemus mentioned this pull request Sep 27, 2025
Open
nicoddemus
nicoddemus reviewed Sep 27, 2025
View reviewed changes
@gomri15 gomri15 force-pushed the 13737-require-unique-paramset-ids branch 2 times, most recently from 907cf3e to 8a770c9 Compare September 27, 2025 16:44
@gomri15
Copy link
Author

gomri15 commented Sep 27, 2025

Should i documentation like there is for --collect-only?

Yes please - and then I think we'll be ready to merge 🙂

Is this till needed or did with @nicoddemus say cover this?
@gomri15 gomri15 force-pushed the 13737-require-unique-paramset-ids branch 2 times, most recently from c0ce285 to a07ff8a Compare September 27, 2025 17:01
Zac-HD
Zac-HD reviewed Sep 30, 2025
View reviewed changes
@gomri15 gomri15 force-pushed the 13737-require-unique-paramset-ids branch from 35da7df to 4d6fa15 Compare October 1, 2025 07:09
@gomri15 gomri15 requested a review from Zac-HD October 1, 2025 07:10
@gomri15 gomri15 force-pushed the 13737-require-unique-paramset-ids branch 3 times, most recently from 71152b2 to 9cebbab Compare October 1, 2025 19:45
gomri15
gomri15 commented Oct 2, 2025
View reviewed changes
Copy link
Author

@gomri15 gomri15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done all fixes
nicoddemus
nicoddemus reviewed Oct 2, 2025
View reviewed changes
nicoddemus
nicoddemus reviewed Oct 2, 2025
View reviewed changes
@nicoddemus
Copy link
Member

@Zac-HD just realized something: doesn't make more sense for this to be an ini option rather than a command-line flag? I understand this is something one would like to setup permanently for a test suite, rather than something to be passed on the command line on occasion.
@Zac-HD
Copy link
Member

Zac-HD commented Oct 3, 2025

doesn't make more sense for this to be an ini option rather than a command-line flag?

Ideally both, I guess?
@gomri15 gomri15 force-pushed the 13737-require-unique-paramset-ids branch from b1bae36 to b825eb4 Compare October 3, 2025 11:41
@gomri15
Copy link
Author

gomri15 commented Oct 3, 2025 •
edited
Loading

doesn't make more sense for this to be an ini option rather than a command-line flag?

Ideally both, I guess?

@nicoddemus, @Zac-HD
added support for the ini flag and tests for it.
@gomri15 gomri15 force-pushed the 13737-require-unique-paramset-ids branch 4 times, most recently from 03b31f8 to 358627e Compare October 3, 2025 19:28
@gomri15 gomri15 force-pushed the 13737-require-unique-paramset-ids branch from 358627e to f547106 Compare October 11, 2025 09:08
@gomri15 gomri15 force-pushed the 13737-require-unique-paramset-ids branch from f547106 to 1d26702 Compare October 11, 2025 15:38
@gomri15 gomri15 requested a review from nicoddemus October 11, 2025 15:40
@gomri15
Copy link
Author

gomri15 commented Oct 11, 2025

@nicoddemus, @Zac-HD I've addressed all issues and added support both as ini and cli param would love to try get this over line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

3 participants

@gomri15 @nicoddemus @Zac-HD