Make log persistency behavior optional #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
work-around for #120
Using
openwitherrorsintroduces different issues with pattern matching and breaks the new logging persistency feature added in0.21.0. However, the issue reported in #120 still persists and trash bytes written by initialized process can potently cause problems. I'll need to revisit that implementation and will probably droppymodule in the process. For now, users having issues with the new logging behavior can opt to go back to the old one by simply callingensurewithpersist_logsset toFalseprocess.ensure(..., persist_logs=False)