Replace imp.load_module() with importlib.machinery #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I think we still support Python 2.6, and IIRC, importlib isn't available on 2.6. So unless we want to drop support for 2.6, we can't unconditionally use importlib (and I'm not sure there's much benefit in doing the conditional dance just to avoid a deprecation). |
| also, if doing this change, I think you may need to update this var too that one contains a gzipped + base64 encoded file that also has a |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
imp.load_module()is deprecated. Replacing it withimportlib.machinery.SourceFileLoader(name, path).load_module()