Removed typing_extensions from vendored dependencies #4347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Avasam commented May 7, 2024
Contributor
| Thank you very much @Avasam. I am in favour of simplifying as much as we can the vendoring. There is a risk it might reappear when we update the vendored dependencies, but should be good for now. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary of changes
Removed
typing_extensionsfrom vendored dependencies.All vendored dependencies put
typing_extensionsbehind aTYPE_CHECKINGblock, in a stub file, or behind a Python 3.8+ check. Hence it is no longer necessary to vendortyping_extensions. (and if a vendored library re-introduce a problem importing it at runtime, we can either raise an issue upstream and wait for the next version, or re-introduce a patch to make it conditional rather than use a vendor version).Closes #4324
Pull Request Checklist
newsfragments/.(See documentation for details)