Pass null datetimes through deserializer #571
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This prevents a crash when a UTCDateTimeAttribute is nullable and is explicitly set to None through Model.update
Author
| The CI failures appear to be spurious; please let me know if you have any questions. |
| I encountered a similar issue with Nullable JSONAttributes , Thanks for the unit test I had initially forgotten to do that in my Pull Request #581 |
ikonst reviewed Jan 15, 2019
| attr = UTCDateTimeAttribute() | ||
| assert attr.deserialize(tstamp.strftime(DATETIME_FORMAT)) == tstamp | ||
| | ||
| def test_utc_date_time_desrialize_none(self): |
Contributor
There was a problem hiding this comment.
Suggested change
| def test_utc_date_time_desrialize_none(self): | |
| def test_utc_date_time_deserialize_none(self): |
Contributor
| This is not specific to UTCDateTimeAttribute, so I don't addressing it for a specific attribute type is correct. Furthermore, this is not a problem when you I guess you're doing something like: my_model.update({ 'my_nullable_date': {'value': None, 'action': 'PUT'}, })while the correct way would be: my_model.update({ 'my_nullable_date': {'action': 'DELETE'}, }) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This prevents a crash when a UTCDateTimeAttribute is nullable and is explicitly
set to None through Model.update