[unbalanced-tuple-unpacking] Add a regression tests for #7710

[Pierre-Sassoulas]

Type of Changes

	Type
✓	🐛 Bug fix

Description

Closes #7710

Require an upgrade in astroid and pylint-dev/astroid#2244 being merged. Will probably fix other issues in other messages whenever sys.argv is used in a check but I don't aim to create exhaustive tests.

[codecov]

Codecov Report

Merging #9041 (2717c53) into main (8231e06) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@ Coverage Diff @@ ## main #9041 +/- ## ======================================= Coverage 95.75% 95.75% ======================================= Files 173 173 Lines 18656 18656 ======================================= Hits 17864 17864 Misses 792 792 

[Pierre-Sassoulas]

When launching all the tests it's not failing, but when launching only the test with pytest -k unbalan it properly fail :

________________________ test_functional[unbalanced_tuple_unpacking] ____________________________ self = <pylint.testutils.lint_module_test.LintModuleTest object at 0x7f8fea7c2dd0> def runTest(self) -> None: > self._runTest() E AssertionError: Wrong message(s) raised for "unbalanced_tuple_unpacking.py": E E Unexpected in testdata: E 169: unbalanced-tuple-unpacking 

Not sure why, but without the astroid upgrade if should fail all the time.

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on pytest:
The following messages are now emitted:

1. deprecated-typing-alias:
   'typing.Callable' is deprecated, use 'collections.abc.Callable' instead
   https://github.com/pytest-dev/pytest/blob/d2b214220f63e1fc90120495d600893cfba6219f/src/_pytest/compat.py#L174
2. deprecated-typing-alias:
   'typing.Callable' is deprecated, use 'collections.abc.Callable' instead
   https://github.com/pytest-dev/pytest/blob/d2b214220f63e1fc90120495d600893cfba6219f/src/_pytest/mark/expression.py#L173

This comment was generated for commit 2717c53

[Pierre-Sassoulas]

Upgrading astroid locally does fix the test when launched with pytest -k unbalan

[jacobtylerwalls]

We can tackle test isolation issues in future work by adding a pytest plugin or some other solution for shuffling test cases.

[github-actions]

The backport to maintenance/2.17.x failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-maintenance/2.17.x maintenance/2.17.x # Navigate to the new working tree cd .worktrees/backport-maintenance/2.17.x # Create a new branch git switch --create backport-9041-to-maintenance/2.17.x # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 65959d3c310f9da6e1d89ace3c1abb3bed4c8757 # Push it to GitHub git push --set-upstream origin backport-9041-to-maintenance/2.17.x # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-maintenance/2.17.x

Then, create a pull request where the base branch is maintenance/2.17.x and the compare/head branch is backport-9041-to-maintenance/2.17.x.