Bug pylint 3468 #3782
Merged
Bug pylint 3468 #3782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…iblings then return is_if_returning
… and adds comments
…nto bug_pylint_3468
… to limit the return statements inside _is_node_return_ended method.
Take into account @Pierre-Sassoulas wise remark. Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
2 tasks
This was referenced Oct 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Steps
doc/whatsnew/<current release.rst>.Description
Thanks to this PR the
inconsistent-return-statementsmessage is emitted in case one oftry/exceptstatement returns explicitly while the other do not.The treatment of
Ifstatement has also been rewritten to deal with the case when there is noorelsepart.Type of Changes
Related Issue
Closes #3468