Skip to content

Conversation

@jacobtylerwalls
Copy link
Member

Type of Changes

Type
🐛 Bug fix

Description

Closes #10664

@jacobtylerwalls jacobtylerwalls added this to the 4.0.2 milestone Oct 18, 2025
@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code C: invalid-name backport maintenance/4.0.x labels Oct 18, 2025
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! The primer issue feel like it's pre-existing (relaunched three time already, sitll failing), I'm not sure when we introduced it or if the stdlib changed. (https://github.com/pylint-dev/pylint/actions/runs/18615113419/job/53080062484)

@codecov
Copy link

codecov bot commented Oct 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.96%. Comparing base (042717c) to head (3e5f056).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@ ## main #10677 +/- ## ======================================= Coverage 95.96% 95.96% ======================================= Files 176 176 Lines 19525 19526 +1 ======================================= + Hits 18738 18739 +1  Misses 787 787 
Files with missing lines Coverage Δ
pylint/checkers/base/name_checker/checker.py 98.72% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@github-actions

This comment has been minimized.

@jacobtylerwalls
Copy link
Member Author

jacobtylerwalls commented Oct 18, 2025

The primer issue feel like it's pre-existing

Reopened #9138 for adding a pytest skip.

@github-actions

This comment has been minimized.

jacobtylerwalls and others added 2 commits October 19, 2025 09:30
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@github-actions
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on music21:
The following messages are now emitted:

  1. invalid-name:
    Constant name "noPIL" doesn't conform to '(([A-Z_][A-Z0-9_])|(.*))$' pattern*
    https://github.com/cuthbertLab/music21/blob/e461154fce0d3675c78d73e847f73b9505561143/music21/lily/translate.py#L45
  2. invalid-name:
    Constant name "noPIL" doesn't conform to '(([A-Z_][A-Z0-9_])|(.*))$' pattern*
    https://github.com/cuthbertLab/music21/blob/e461154fce0d3675c78d73e847f73b9505561143/music21/lily/translate.py#L47
  3. invalid-name:
    Constant name "noPIL" doesn't conform to '(([A-Z_][A-Z0-9_])|(.*))$' pattern*
    https://github.com/cuthbertLab/music21/blob/e461154fce0d3675c78d73e847f73b9505561143/music21/lily/translate.py#L49

Effect on django:
The following messages are now emitted:

  1. invalid-name:
    Constant name "lib_names" doesn't conform to UPPER_CASE naming style
    https://github.com/django/django/blob/b1e0262c9f9d11eae6230b51c5aa5d71122d5f05/django/contrib/gis/gdal/libgdal.py#L21

Effect on psycopg:
The following messages are no longer emitted:

  1. invalid-name:
    Constant name "_epoll_evmasks" doesn't conform to UPPER_CASE naming style
    https://github.com/psycopg/psycopg/blob/a603ab39b6644a569947a7e1ff29ac0945bf18f4/psycopg/psycopg/waiting.py#L292
  2. invalid-name:
    Constant name "_epoll_evmasks" doesn't conform to UPPER_CASE naming style
    https://github.com/psycopg/psycopg/blob/a603ab39b6644a569947a7e1ff29ac0945bf18f4/psycopg/psycopg/waiting.py#L298
  3. invalid-name:
    Constant name "_poll_evmasks" doesn't conform to UPPER_CASE naming style
    https://github.com/psycopg/psycopg/blob/a603ab39b6644a569947a7e1ff29ac0945bf18f4/psycopg/psycopg/waiting.py#L349
  4. invalid-name:
    Constant name "_poll_evmasks" doesn't conform to UPPER_CASE naming style
    https://github.com/psycopg/psycopg/blob/a603ab39b6644a569947a7e1ff29ac0945bf18f4/psycopg/psycopg/waiting.py#L356

This comment was generated for commit 3e5f056

@jacobtylerwalls jacobtylerwalls merged commit 6678c90 into pylint-dev:main Oct 19, 2025
42 of 44 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/multiple-branches branch October 19, 2025 14:06
pylint-backport bot pushed a commit that referenced this pull request Oct 19, 2025
jacobtylerwalls added a commit that referenced this pull request Oct 19, 2025
…l constant with multiple branches (#10684) Fix FP for `invalid-name` on module-level constant with multiple branches (#10677) (cherry picked from commit 6678c90) Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport maintenance/4.0.x C: invalid-name False Positive 🦟 A message is emitted but nothing is wrong with the code

2 participants