Skip to content

Deprecate PyLinter pylintrc argument #10620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2025
Merged

Deprecate PyLinter pylintrc argument #10620

merged 3 commits into from
Oct 6, 2025

Conversation

@jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Oct 5, 2025 •
edited
Loading

This was unused.
@jacobtylerwalls jacobtylerwalls added this to the 4.0.0 milestone Oct 5, 2025
@jacobtylerwalls jacobtylerwalls added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Oct 5, 2025
DanielNoord
DanielNoord reviewed Oct 5, 2025
View reviewed changes
pylint/lint/pylinter.py
option_groups: tuple[tuple[str, str], ...] = (),
# TODO: Deprecate passing the pylintrc parameter
pylintrc: str | None = None, # pylint: disable=unused-argument
pylintrc: str | None = None,
Copy link
Collaborator

@DanielNoord DanielNoord Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use a sentinal object as default value so that we can explicitly check whether people are passing None here?
Copy link
Member Author

@jacobtylerwalls jacobtylerwalls Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I wasn't sure whether to bother?
Copy link
Collaborator

@DanielNoord DanielNoord Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should? That hopefully also unblocks our CI 😄
@github-actions

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented Oct 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.95%. Comparing base (8fd96fa) to head (0e918f4).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
pylint/lint/pylinter.py 66.66% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@ ## main #10620 +/- ## ========================================== - Coverage 95.96% 95.95% -0.01%  ========================================== Files 176 176 Lines 19470 19504 +34 ========================================== + Hits 18684 18716 +32  - Misses 786 788 +2
Files with missing lines Coverage Δ
pylint/lint/run.py 93.91% <ø> (ø)
pylint/lint/pylinter.py 96.23% <66.66%> (-0.17%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@github-actions

This comment has been minimized.

Sign in to view
Pierre-Sassoulas
Pierre-Sassoulas previously approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch !
@jacobtylerwalls @Pierre-Sassoulas
Update warning text
0e918f4 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@jacobtylerwalls jacobtylerwalls merged commit a07eca7 into pylint-dev:main Oct 6, 2025
32 of 33 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/deprecate-pylintrc-arg branch October 6, 2025 15:01
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 0e918f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Discussion or action around maintaining pylint or the dev workflow

3 participants

@jacobtylerwalls @Pierre-Sassoulas @DanielNoord