Fix Mermaid printer rendering double underscores as bold formatting #10403
+40 −22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@ ## main #10403 +/- ## ======================================= Coverage 95.90% 95.90% ======================================= Files 176 176 Lines 19130 19138 +8 ======================================= + Hits 18347 18355 +8 Misses 783 783
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas previously approved these changes May 25, 2025
There was a problem hiding this comment.
LGTM, thank you. Let's wait for @DudeNr33 review before merging.
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
DudeNr33 approved these changes May 29, 2025
pylint-backport bot pushed a commit that referenced this pull request May 29, 2025
…10403) * Escape characters in mermaid viewer * Update test files * Add news fragement * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Apply suggestions from code review Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> (cherry picked from commit 25a0f9e)
Pierre-Sassoulas added a commit that referenced this pull request May 29, 2025
Pierre-Sassoulas added a commit that referenced this pull request Aug 9, 2025
…10487) * [ci] Install pylint before every test (#10388) (#10389) Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> * Improve backport job permissions (#10390) (#10391) (cherry picked from commit 222ab20) * Resolve `possibly-used-before-assignment` false positives from `match` block assignments (#10393) (cherry picked from commit ad14b5b) * Use custom Github App to authenticate backport job (#10394) (#10396) (cherry picked from commit 6be8676) Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> * Fix Pyreverse: Aggregations aren't filtered according to filter mode (PUB_ONLY, etc.) (#10379) (#10401) * updated diagrams.py file * added tests * updated tests * added test cases * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- (cherry picked from commit ed59632) Co-authored-by: pavan-msys <149513767+pavan-msys@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Fix Mermaid printer rendering double underscores as bold formatting (#10403) (#10410) (cherry picked from commit 25a0f9e) Co-authored-by: Julian Grimm <51880314+Julfried@users.noreply.github.com> Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com> * Respect docstring-min-length in docparams extension (#10104) (#10434) (cherry picked from commit 7f5e996) Co-authored-by: Berker ŞAL <brkr.sal@gmail.com> * Fix `unused-variable` false positive when using same name for multiple exceptions (#10436) (#10481) (cherry picked from commit 9e72867) Co-authored-by: Zen Lee <53538590+zenlyj@users.noreply.github.com> * Fix false-negative for used-before-assignment with postponed evaluation in function defs (#10482) (#10483) (cherry picked from commit d363fca) Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> * Update pytest-benchmark requirement from ~=4.0 to ~=5.1 (#10066) (#10484) (cherry picked from commit f04761b) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pylint to 3.3.8, update changelog (#10486) --------- Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com> Co-authored-by: pylint-backport-bot[bot] <212256041+pylint-backport-bot[bot]@users.noreply.github.com> Co-authored-by: pavan-msys <149513767+pavan-msys@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Julian Grimm <51880314+Julfried@users.noreply.github.com> Co-authored-by: Berker ŞAL <brkr.sal@gmail.com> Co-authored-by: Zen Lee <53538590+zenlyj@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Pierre-Sassoulas temporarily deployed to Backport 
GitHub Actions Inactive Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
For now I am only escaping __, but other characters can easily be added aswell :)
Closes #10402