[fix] Fix crash when inferring namedtuple with invalid field name #2806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@ ## main #2806 +/- ## ======================================= Coverage 93.30% 93.31% ======================================= Files 91 91 Lines 11091 11094 +3 ======================================= + Hits 10349 10352 +3 Misses 742 742
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
Pierre-Sassoulas previously approved these changes Aug 21, 2025
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Pierre-Sassoulas approved these changes Aug 21, 2025
| I'm going to wait for another maintainer's opinion before merging, nothing to do on your side @Synrom |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #2519