- Notifications
You must be signed in to change notification settings - Fork 5
Update scipy to 1.16.0 #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Estimated code review effort1 (~2 minutes) Possibly related PRs
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #346 +/- ## ======================================= Coverage 81.15% 81.15% ======================================= Files 5 5 Lines 552 552 ======================================= Hits 448 448 Misses 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
40-42: Pin update LGTM – keep an eye on tight version lock.Exact pinning (
==1.16.0) ensures full reproducibility and matches the other env files, so 👍. Just remember this prevents automatic uptake of patch releases; if that becomes a maintenance burden consider a~=1.16spec instead.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.ci_support/environment-mpich.yml(1 hunks).ci_support/environment-openmpi.yml(1 hunks)binder/environment.yml(1 hunks)pyproject.toml(1 hunks)
🔇 Additional comments (3)
binder/environment.yml (1)
10-10: Confirm availability ofscipy 1.16.0on conda-forge for all supported Python versions.The bump itself looks correct, but because this file is consumed by Binder (potentially on multiple Python minor versions), please double-check that
scipy =1.16.0is already published for every interpreter listed inrequires-python(3.9–3.12). A missing build will break the environment solve.If everything is present, no further changes are needed.
.ci_support/environment-openmpi.yml (1)
11-11: Verify new SciPy build exists for the OpenMPI stack.Identical note as for Binder: ensure
conda-forge/linux-*(and os-x) binaries ofscipy 1.16.0built with OpenBLAS are already available; CI will fail early otherwise..ci_support/environment-mpich.yml (1)
11-11: Consistency check passes; please run a quickmamba env createlocally.The version bump is consistent across all env files; a local solve with
mamba(or the CI matrix) will confirm there are no hidden conflicts withmpichbuilds.
Summary by CodeRabbit
scipypackage to 1.16.0 in all environment and configuration files.