-   Notifications  
You must be signed in to change notification settings  - Fork 5
 
Update executorlib to 1.6.0 #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
 WalkthroughThis update raises the version of the  Changes
 Possibly related PRs
 Suggested labels
 Poem
 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit: 
 SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
 Other keywords and placeholders
 CodeRabbit Configuration File (  |  
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
26-30: Pin build-time requirement or loosen runtime pin forexecutorlib.Runtime dependency is now
executorlib==1.6.0, but[build-system].requiresstill lists an unpinnedexecutorlib.
If the project actually needsexecutorlibduring build, mismatched versions could slip in when 1.7+ appears.Options:
-requires = ["mpi4py", "numpy", "executorlib", "setuptools", "versioneer[toml]==0.29"] +requires = ["mpi4py", "numpy", "executorlib==1.6.0", "setuptools", "versioneer[toml]==0.29"]—or—relax the runtime spec to
executorlib>=1.6,<2for a single source of truth.Please verify the intended constraint strategy.
📜 Review details
Configuration used: CodeRabbit UI
 Review profile: CHILL
 Plan: Pro
📒 Files selected for processing (4)
.ci_support/environment-mpich.yml(1 hunks).ci_support/environment-openmpi.yml(1 hunks)binder/environment.yml(1 hunks)pyproject.toml(1 hunks)
🔇 Additional comments (3)
.ci_support/environment-mpich.yml (1)
9-9: Version bump looks consistent – no further action needed.
executorlibis now aligned with the other environment files andpyproject.toml.
No breaking changes expected..ci_support/environment-openmpi.yml (1)
9-9: Dependency pin aligned across configs – LGTM.
executorlib =1.6.0matches the MPICH config and project metadata, ensuring consistency.binder/environment.yml (1)
4-8: Double-check availability of pinned versions in the Binder image.•
numpy =2.3.1andlammps =2024.08.29=*_mpi_openmpi_*are very new; wheels/conda builds may not yet be published onconda-forgeat Binder build time.
•openmpiis unpinned here while other CI envs pinopenmpi =5.0.8. Mixed MPI stacks can break runtime compatibility.Consider:
- openmpi + openmpi =5.0.8and verify that all pinned versions exist on
conda-forge.
 Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@ Coverage Diff @@ ## main #342 +/- ## ======================================= Coverage 81.02% 81.02% ======================================= Files 5 5 Lines 548 548 ======================================= Hits 444 444 Misses 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  |  
Summary by CodeRabbit