support ‘options’ kwarg in XLSXWriter.open() #3
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #3 +/- ## ========================================== + Coverage 98.42% 98.47% +0.04% ========================================== Files 8 8 Lines 381 393 +12 ========================================== + Hits 375 387 +12 Misses 6 6
Continue to review full report at Codecov.
|
| _date_format: 'dd/mm/yy', | ||
| 'constant_memory': True | ||
| } | ||
| options = keywords.get('options', {}) |
There was a problem hiding this comment.
I would suggest to remove 'options' keyword, but instead using keyword as options itself. Your implementation is alright but just because I have used keywords as direct options in other plugins, it will be good to keep the consistency.
| # for backward compatibility, let the top-level kwarg take precedence | ||
| options[_date_format] = keywords.get( | ||
| _date_format, | ||
| options[_date_format]) |
There was a problem hiding this comment.
And then put in default options, pass it on
self._native_book = xlsxwriter.Workbook(
file_name, keywords # <--
)
| Thanks for the quick review and feedback! I've implemented your suggested changes in #4. |
3 participants
Fixes #1