Skip to content

Conversation

prady0t
Copy link
Collaborator

@prady0t prady0t commented Jul 26, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Related issues

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Copy link

codspeed-hq bot commented Jul 26, 2025

CodSpeed Performance Report

Merging #891 will not alter performance

Comparing prady0t:making-benchmarking-deterministic (b1a10c6) with main (d27f795)1

Summary

βœ… 340 untouched benchmarks

Footnotes

  1. No successful run was found on main (b1a10c6) during the generation of this report, so d27f795 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to make the seed usable across tests. If a subset of tests is selected, this is no longer reproducible in its current form, because the generator is mutated by each test.

prady0t and others added 2 commits July 27, 2025 14:28
Co-authored-by: Hameer Abbasi <2190658+hameerabbasi@users.noreply.github.com>
Co-authored-by: Hameer Abbasi <2190658+hameerabbasi@users.noreply.github.com>
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks, @prady0t. Feel free to hit merge.

@prady0t prady0t merged commit 32ab23d into pydata:main Jul 27, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants